timothy1ee
commented
11 years ago Sorry for the delayed review. The parts that you have completed looks great. It's good practice tuning these minor details.
Check out this project, you might like it: https://github.com/youknowone/UI7Kit. It brings the iOS 7 style back to iOS 6 with just one line of code.
- For your compose view, note that you rarely want to use the navigation bar directly. Instead, consider embedding the compose view in it's own navigation controller.
- Your constraints look good, glad you discovered the topLayoutGuide. There's also a bottomLayoutGuide that you might find handy one day.
- For non-editable text, it's more common to use UILabel than it is to use UITextView.
- Consider creating a property for the tweet in the TweetCell. In a custom setter, you can have the TweetCell configure its views based on the Tweet. Move the height calculation to a static method in TweetCell. This is more modular, and will make it easier to share your TweetCell with the user profile page you started building.
- Check out a concept called "appearance proxies". Instead of configuring your navigation bar in multiple classes, you can configure its view just once.
- I see you discovered categories. Categories are awesome.
- Consider reloading the twitter feed after the compose. A slightly better alternative would be to pass the created tweet back into the feed locally, so it'll be there immediately even with slow internet.
The main takeaways for this homework were:
- How to handle dynamically sized rows in table views.
- How to implement and debug Auto Layout in the Tweet Cell, Compose view, and Tweet view.
- How to implement nav stack and modal navigation.
- How to augment a networking client.
- How to augment a model, adding serialization/deserialization code, and formatting code.
Here's my checklist of things I'm looking at when I'm reviewing this project.
- Is the Objective-C code styling consistent with standards?
- Did you augment the API client with the methods for updating status, reply, retweet, favorite? Note that there is a separate endpoint for removing a retweet or favorite.
- Did you augment the Tweet model? Note that for the embedded user, you should instantiate a User object and have the User class do the deserialization, instead of navigating to user.screen_name in the Tweet model.
- Were the Auto Layout constraints correct for all the views?
- Was the navigation implemented correctly either manually or via segues?
- Was pull to refresh implemented?
- Was infinite scrolling implemented?
Hey Tim (@timothy1ee),
Here's my submission for the Twitter Client. Everything looks fine on iOS 7 but things end up looking funky on iOS 6. For some reason switching between the two views within Xcode really screw things up even when using Auto Layout.
All the required functionality is there and the optional pull to refresh. I have the beginnings of the infinite loading but ended commenting it out due to a bug that causes me to get rate limited quickly.
edit I managed to fix a number of the auto layout issues when switching between the 2 ios versions and switching between 3.5" and 4".