Open felixwellen opened 1 year ago
Ah. I misread... I thought std-
means standard in the sense of standard open....
Should we rename that?
Right, the name std-qc-open-prop
is not very good. But I don't know what to call it right now.
By the way the D(f) should I think be called "basic open" to be clear (not "standard open").
Maybe call std-qc-open-prop
just contains-invertible-prop
!
Yes. I guess then it is all good and it's just me ;-) Standard open in the sense we have now actually fits well with standard finite.
Maybe call
std-qc-open-prop
justcontains-invertible-prop
!
That would have prevented me from misreading.
Not sure about the -prop
, but I think it is a good name.
Not sure about the
-prop
Yes, I see. An alternative would be to bundle the hProp right away and just have:
contains-invertible : {n : ℕ} → FinVec ⟨ k ⟩ n → hProp _
contains-invertible v = ∥ Σ[ i ∈ Fin _ ] (v i) ∈ k ˣ ∥ₚ
(Or with ∃
and isPropPropTrunc
.)
Yes, I think this (with ∃
) should be the best way to do it (unless we use the non-prop version a lot, but I don't think we do or will).
I think our definition of open propositions is wrong.
is-qc-open
says that a propositionP
is open iff there are $n\in\mathbb N$ and a vectorv
of length n such that there is ani
such that $P$ is equivalent tov i
being invertible. But we should askP
to be equivalent to the existence of ani
such thatv i
is invertible. This means that the proof that open propositions are double negation stable does not work as it is now. Don't know if this affects anything else.