Some settings improvements

felixwiemuth / SimpleReminder

Efficient creation of simple reminders on Android.

Other

57 stars 9 forks source link

Some settings improvements #11

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 3 years ago

1st commit

Use SwitchPreferenceCompat (from #8)

2nd commit

Use FragmentContainerView for the settings fragment (go here, do Ctrl + F, and put "FragmentContainerView" in the box to see related info and changes, as well as the reasons for its creation)

3rd commit

Remove redundant getPreferenceScreen calls
Don't reserve icon space for settings without icons (this makes the settings look nicer margin-wise)

felixwiemuth commented 3 years ago

This looks good.

Thanks also for the third commit, I already noticed the space next to each preference and that actually many apps have it and was wondering where it comes from. Could you please change the commit title and message to something more descriptive? Basically what you already wrote in the description here is fine.

felixwiemuth commented 3 years ago

Thanks! I added you to the contributors list (which in addition might be shown in the app), do you want anything changed for your entry? You can choose a different display name (the link will always be to the Github profile) and optionally have an email address added.

TacoTheDank commented 3 years ago

@felixwiemuth Nope, you can just keep it as is if you wish :)

felixwiemuth commented 3 years ago

Okay, thanks again for your effort! If you are interested in contributing more, let me know and we can have a chat. :)