felixzapata / gulp-axe-webdriver

Gulp plugin for aXe utilizing WebDriverJS
MIT License
24 stars 7 forks source link

Update axe-webdriverjs to the latest version #8

Closed kaelig closed 7 years ago

kaelig commented 7 years ago

Update: fixed! Pending fix of this issue: https://github.com/dequelabs/axe-webdriverjs/issues/23

Change Log

0.5.0 - 2016-12-22

Added

Changed

~~Here's an open issue, please chime in if you'd like release notes in axe-webdriverjs! https://github.com/dequelabs/axe-webdriverjs/issues/22~~ There is now a change log :)

kaelig commented 7 years ago

cc @SiTaggart

felixzapata commented 7 years ago

hi, I can´t merge this pull request until the new version being released.

kaelig commented 7 years ago

@felixzapata correct, I was a bit too eager :) Merging this PR is pending fix of this issue: dequelabs/axe-webdriverjs#23

kaelig commented 7 years ago

@felixzapata I updated the PR pointing to the latest version (0.5.0) that was released yesterday.

felixzapata commented 7 years ago

Hi @kaelig , happy holidays. Can you update the package.json file to bump the selenium-webdriver from ^2.53.3 to ^3.0.0.

It is necessary in order to avoid this warn: npm WARN axe-webdriverjs@0.5.0 requires a peer of selenium-webdriver@^3.0.0 but none was installed

kaelig commented 7 years ago

@felixzapata done, happy holidays to you too!

felixzapata commented 7 years ago

hi @kaelig, I've released the version 1.4.0.

Thanks for your pull request.

kaelig commented 7 years ago

Thank you @felixzapata! v1.4.0 doesn't show up in the npm registry yet, is this normal?

felixzapata commented 7 years ago

Hmmm.. it is not normal because a few hours ago I published without errors and now, I did it again and it says, again, no errors:

20:00 ~/$ npm publish ./
+ gulp-axe-webdriver@1.4.0

I don't know if there is some error in the npm registry

kaelig commented 7 years ago

Looks good now, thanks!

felixzapata commented 7 years ago

I don't know if is cache or what, but sometimes in the npm registry it shows the last version and other times it shows the previous version. I've checked it with npm semver calculator and always shows the last version.