felko / neuron-mode

An emacs mode for editing Zettelkasten notes with neuron
GNU General Public License v3.0
118 stars 21 forks source link

Repair `neuron-title-overlay-face', resolving compiler error #32

Closed pjones closed 4 years ago

pjones commented 4 years ago

neuron-title-overlay-face was missing a level of nesting which caused the following compiler error:

Debugger entered--Lisp error: (wrong-type-argument listp class)
  face-spec-set-match-display((class color) #<frame F1 0xa967b0>)
...
felko commented 4 years ago

Thanks for catching that. How did you find it? M-x byte-compile-file did not detect this error.

pjones commented 4 years ago

Thanks for catching that. How did you find it? M-x byte-compile-file did not detect this error.

I first noticed it by compiling a file that had (require 'neuron-mode) in it. I would get a compile error but it would only identify the require line, not the real source.

I eventually found it by toggle-debug-on-error in a fresh Emacs instance before loading neuron-mode.el and running eval-buffer.