felko / neuron-mode

An emacs mode for editing Zettelkasten notes with neuron
GNU General Public License v3.0
118 stars 21 forks source link

Allow the user to create a new tag using `neuron--select-tag-from-query' #33

Closed pjones closed 4 years ago

pjones commented 4 years ago

If the user enters a tag name that does not exist ivy-read will return it, but then get-text-property will return nil. In that case just return the user-entered text.

felko commented 4 years ago

Good idea, thank you. I believe neuron--select-tag-from-query should rather take an optional require-match argument that controls this behavior, because in some cases (e.g. in neuron-query-tags) we actually want the user to select an existing tag. Also, I was thinking maybe entering a new tag could reload the zettel cache?

pjones commented 4 years ago

Good ideas. I'll update this PR.

pjones commented 4 years ago

@felko I added the require-match argument and the cache rebuild.

felko commented 4 years ago

Thank you!