search

fellesverkstedet / Bark-beetle-parametric-toolpaths

A grasshopper plugin for digital fabrication. Enables direct fabrication of geometry with 3D printers, CNC milling, Laser cutters, Robot arms and more. Also featuring 1:1 augmented reality toolpath projections.
97 stars 18 forks source link

Pocket with curves inside that form an island get recognized as a curve inside a curve #39

Closed Siemenc closed 6 years ago

Siemenc commented 6 years ago

See example below: Area with X should create a pocket as well. But in current logic it defines it as an area inside an area and therefore skipping it. image

Siemenc commented 6 years ago

Here's another example of issues with curves inside inside. This works well: image Now if I add these curves on the bottom right, it messes up the inside inside. image

Siemenc commented 6 years ago

With sorting out the offset component as described in #41 I also fixed these issues. Very satisfying to see these special cases being calculated. Even a tiny bit faster than the old offset componentimage

JensDyvik commented 6 years ago

Greeeeeeeeeeeeeeat! As mentioned in the other issues, the improved pocket function is now included in the latest CNC milling example. https://github.com/fellesverkstedet/Bark-beetle-parametric-toolpaths/commit/b1dd65f60118ba676e5350a7cde896db4f392525