search

fellinga / node-red-contrib-ui-time-scheduler

Easily power on/off any kind of device based on a schedule that you can easily create at the node-red-dashboard frontend.
MIT License
37 stars 17 forks source link

Bug default mode after midnight? #78

Open fertiltech opened 2 years ago

fertiltech commented 2 years ago

Hi, thank you for the node, it's very powerful!.

I think there is a bug about the time after midnight in the default mode. the single off and block are flagged.

if I set "on" at 23:00 and "off for example at 01.05 (where he tells you the time exceeds midnight, do you confirm?) the "on" it's ok, but the off doesn't work. I read the enddtime timestamp in the payload and it is correct but it does not send the payload.

I'm pretty sure it worked a few months ago. is not that with the change to summer time has given problems?

thank you for your time

P.s. another idea to improve the program: it would be great if the device name were a variable, so you can change the name directly from the ui!

JosM60 commented 10 months ago

Ran into this too, can be bypassed by adding another on - off block, switching on after midnight and off at the required time. But a fix would be nicer. Next to that, great tool, felxible and easy to use.

fellinga commented 10 months ago

I haven't updated the node in quite a while so if it worked a few months ago it might has something to do with the winter/summer time bug.

@fertiltech @JosM60 can you try to delete all existing "over-midnight schedules" (deletion is important for this test), recreate them and give feedback if the error still exists?