search

felskrone / salt-eventsd

events-listener daemon for saltstack that writes data into a database
Other
52 stars 12 forks source link

Worker: Centralize DB config & wrong comment? #2

Closed syphernl closed 10 years ago

syphernl commented 10 years ago

The comments in the worker mention

    # the settings for the mysql-server to use
    # it should be a read-only user, it just collects data

I assume this is "write only" instead? Otherwise it cannot insert data into the database :)

The 3 workers included all require to be configured manually with DB credentials. Its probably more practical (unless there are reasons for not doing it) to move those to a central location instead (e.g. the /etc/salt/eventsd file)?

felskrone commented 10 years ago

thx, that comments are fixed.

The workers can pretty much be or do anything upon receiving an event.

Having the config centralized would mean to clutter the configs with (maybe different/various) credentials/settings for each worker.

Im not really against it, but i dont really see the benefit to configure a worker in the config.

syphernl commented 10 years ago

Chances are that people use the same configs for workers, or atleast the same credentials. Having them in a source-file is not very practical imho.

felskrone commented 10 years ago

Agreed. But i will fix the reported bugs first. Feel free to send a pull request that adds this functionality :-)

Are you on IRC by any chance?

syphernl commented 10 years ago

There's no rush, this is just a "nice to have" in order to make it a little cleaner. I'm "always" on IRC (both #salt and #salt-devel) so feel free to contact me there! :)

felskrone commented 10 years ago

worker config has been centralized in eventsd config with the option to define one set of credentials for all worker or credentials for each worker independently.

syphernl commented 10 years ago

Central DB config works like a charm!