search

felt / qgis-plugin

GNU General Public License v2.0
24 stars 5 forks source link

Minor refactoring: consolidate felt.com reference to single variable #62

Closed springmeyer closed 6 months ago

springmeyer commented 7 months ago

This will support easier manual local testing of the plugin against our live testing environments (to ensure the plugin works against future versions of the Felt API).

nyalldawson commented 7 months ago

Could we move constants.py to core instead? That keeps the separation of core classes nicely.

springmeyer commented 7 months ago

Could we move constants.py to core instead? That keeps the separation of core classes nicely.

@nyalldawson absolutely. I noticed that some things in core are exposed via the __init__.py to the gui side of things, so I moved to /core/constants.py and exposed in __init__.py. Let me know if that is what you had in mind.

springmeyer commented 6 months ago

@nyalldawson - does this look good to merge now?