search

felvin-search / instant-apps

Your search box is now an app store! 🎉
https://felvin.com
Other
94 stars 47 forks source link

[Proposal] Search Icon should be clickable #334

Closed Sync271 closed 2 years ago

Sync271 commented 2 years ago

Summary

On most search engines, the search icon is clickable and it also feels intuitive to click on it.

Screenshot 2022-03-08 at 5 52 25 PM

Example search queries

None

Implementation (optional)

Just wrap the current Icon component with a span and add submit option to it. Following line should be the relevant place to make the modification. https://github.com/felvin-search/instant-apps/blob/master/packages/sandbox/src/components/SearchBox.tsx#L104

Context

This issue is there only on the sandbox.felvin.com, things work fine on felvin.com

hargup commented 2 years ago

@Sync271 thanks for reporting this @Sync271, I have added a screenshot and few more additional details to help a contributor pick up this issue.

Sync271 commented 2 years ago

@hargup can I pick this up or do you want someone else to do it?

hargup commented 2 years ago

Feel free to pick it up