search

fema-ffrd / rashdf

Read data from HEC-RAS HDF files.
MIT License
9 stars 1 forks source link

Feature/ras 1d #55

Closed sray014 closed 4 months ago

sray014 commented 4 months ago

Adds functions to export the following 1D Output data from HDF files as well as unit tests for each function:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.14563% with 5 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/rashdf/plan.py 99.02% <100.00%> (+0.17%) :arrow_up:
src/rashdf/geom.py 84.51% <91.07%> (+3.46%) :arrow_up:
sduncan4 commented 4 months ago

@sray014 and @slawler , I've made the adjustments to geom.py for the encroachments functions. Please review.

sray014 commented 4 months ago

@thwllms I assume the version in the pyproject.toml will need to be bumped up to 0.3.1?

thwllms commented 4 months ago

@thwllms I assume the version in the pyproject.toml will need to be bumped up to 0.3.1?

I'd bump to 0.4.0 since this adds new features. A +0.0.1 bump would be appropriate for a bugfixes-only update.

slawler commented 4 months ago

@thwllms Looks like the issues have been resolved, I approved, will wait for you to merge once you've had a chance to review.

sray014 commented 4 months ago

@thwllms does fiona need to be added to the pyproject dependencies for those checks to work? Not sure why it worked on the previous commit and not this one since nothing changed that deals with that.

thwllms commented 4 months ago

@thwllms does fiona need to be added to the pyproject dependencies for those checks to work? Not sure why it worked on the previous commit and not this one since nothing changed that deals with that.

Looks like this is happening because GeoPandas 1.0.0 was just released a few hours ago and I guess it doesn't rely on Fiona as an explicit dependency anymore. We were previously relying on version ~0.14. For now let's pin GeoPandas to version number 0.14 and create an issue to upgrade to 1.0.0.

In pyproject.toml:

name = "rashdf"
description = "Read data from HEC-RAS HDF files."
readme = "README.md"
classifiers = [
    "Development Status :: 4 - Beta",
    "Intended Audience :: Developers",
    "License :: OSI Approved :: MIT License",
    "Programming Language :: Python :: 3",
    "Programming Language :: Python :: 3.9",
    "Programming Language :: Python :: 3.10",
    "Programming Language :: Python :: 3.11",
    "Programming Language :: Python :: 3.12",
]
version = "0.4.0"
dependencies = ["h5py", "geopandas>=0.14,<0.15", "pyarrow", "xarray"]

https://pypi.org/project/geopandas/#history