60 observed flow and stage data

fema-ffrd / rashdf

Read data from HEC-RAS HDF files.

MIT License

8 stars 1 forks source link

60 observed flow and stage data #61

Closed zherbz closed 5 days ago

zherbz commented 1 month ago

Added functionality to acquire observed data from the hdf file for both reference line and point locations related to stage and flow.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines	Coverage Δ
src/rashdf/plan.py	`97.38% <100.00%> (+0.19%)`	:arrow_up:

zherbz commented 1 week ago

Thanks for the great feedback! Just addressed all comments and sent back your way.

thwllms commented 1 week ago

@zherbz:

Got some comments above still outstanding
Code coverage is failing, meaning that there are untested lines in your changes. Seems like these are error paths -- just need to add a couple tests to verify that the correct errors are raised under expected conditions

zherbz commented 6 days ago

@zherbz:

Got some comments above still outstanding

Code coverage is failing, meaning that there are untested lines in your changes. Seems like these are error paths -- just need to add a couple tests to verify that the correct errors are raised under expected conditions

Additional tests added and now able to merge once approved