femboyindustries / gimmick-theme

A minimal NotITG v4.3.0 theme focused on developer simplicity and modern solutions
2 stars 0 forks source link

Quirk Options for 16:9/etc #21

Open Jecket22 opened 1 month ago

Jecket22 commented 1 month ago

Oat and Mayflower currently make the theme work primarily in 16:9; whilst we should target making the theme work with 4:3 as well, an idea came up. Would it be a good idea to give the user an option to change the behavior of the applied aspect ratio for modfiles? I have a small list of what it could look like:

Do not change anything The theme will simply not apply any changes - the file will play out like any other theme Improve compatibility The theme may inject changes to get rid of problematic issues Force 4:3 during gameplay ...by resizing the window The theme will resize the window before the modfile starts. For fullscreen the theme will add an artificial delay so the monitor can take a moment to properly change the resolution. ...by emulating it The theme will temporarily modify/mixin variables and functions to make the game pretend it's running on 4:3. Letterboxing could be added and some modfiles might still require other quirks. ...by stretching it Simply changes the aspect ratio whilst keeping the resolution, making the game look stretched. This feature has a target audience of 2.

EDIT: Oat suggested we should put these types of options in the player options / mod select menu (the one that displays after selecting a song)

oatmealine commented 1 month ago

i don't see a reason to have anything beyond letterboxing, everything else is going to get confusing to explain to a beginner for such a core feature and is best tucked away, if even implemented at all (who the hell would want stretched 4:3 in modfiles but not in the theme?)