femiguez / apsimx

R package for APSIM-X
https://femiguez.github.io/apsimx-docs/
51 stars 20 forks source link

Running check #144

Closed femiguez closed 8 months ago

femiguez commented 9 months ago

The following problems arise when running check

LenLon commented 9 months ago

Curious thing - if you use inspect_apsimx() it shows these as Soil children, but when you try to access them and throws an exception because e.g. "NO3" is not part of the predefined parameter set :-D

femiguez commented 9 months ago

@LenLon Thanks for the comment. I am aware of this and I will make changes to address it. For less common (or newer) 'inspect' type of tasks you can use either 'inspect_apsimx_replacements' or 'inspect_apsimx_json'.

LenLon commented 8 months ago

It is not possible to edit these parameters then, though, correct?

I am getting Initial soil water contents of 400+ mm, (Fractions of > 200%) using the ISRIC soil profiles, so this also ties into the issue of APSIM-X not even encoding that fraction anywhere in the .apsimx file :/

Edit:

You are able to edit the value using edit_apsimx() and node="Other" with the parm.path extracted by inspect_apsimx_json() The value is changed in the .apsimx file, but APSIM-X then shows the value as "NaN" in the GUI and if you save overwrites it as well in the file.

femiguez commented 8 months ago

APSIM does have some weird behavior. As you know, all the package allows to do is to change the text in the .apsimx file. If APSIM does weird things later, there is not much I can do about that. It will probably be a while until I can look at this, because I have other priorities. :)

LenLon commented 8 months ago

An addendum: Does the function edit_apsimx_replace_soil_profile() still function correctly with the renamed soil parameters?

After using the function, I am seeing different layer structures for the soil water properties and the NO3/NH4/Urea tabs, though I am not sure if that is the GUI or an actual issue with the soil profile:

NO3 image

Physical image

femiguez commented 8 months ago

@LenLon Sorry for the delay. You have probably figure out by now that the layers in APSIM do not need to agree between Physical and NO3 for example.

Also, I'm closing this as the package seems to be able to handle the changes they have made recently