femtopixel / docker-google-lighthouse

Google Lighthouse - Docker Image
https://brands.jaymoulin.me/femtopixel/docker-google-lighthouse
MIT License
70 stars 23 forks source link

Clarify need for --security-opt in docs #12

Closed jareware closed 5 years ago

jareware commented 5 years ago

Some environments (e.g. Bitbucket Pipelines) don't allow options such as --security-opts for Docker, but as it turns out, this image runs just fine without that option. 🎉

So... why is this option suggested in the docs? Am I missing something? My reports (seem to) contain all the expected things.

jaymoulin commented 5 years ago

The option is suggested to avoid use of --cap-add=SYS_ADMIN which is a bit overkill (option you may use in your pipeline).

As --security-opt and --cap-add are Docker specific parameters, I won't explain in details how to use it. A better documentation already cover this topic : https://docs.docker.com/engine/security/seccomp/

I'm glad you were able to make report through your pipeline (which is the targeted purpose of this image ;))

jareware commented 5 years ago

Thanks for the thorough response!

I may have worded my question poorly. Let me try again:

Should the docs continue to suggest the use of --security-opt and --cap-add even though it seems they're not needed? I'm getting the exact same Lighthouse report with and without those options.

Feel free to ignore me if you feel like this is irrelevant, just wanted to try and help others who might want to run this image in an environment that doesn't allow using those options. :)

jaymoulin commented 5 years ago

Oh! you're right these parameters seems not needed anymore with the chromium update. They were required with a previous chromium revision to be able to launch its instance