search

fendersperth / fendersbot

A group project for learning and teaching via a real code base
9 stars 3 forks source link

[WIP] Add Meetup API integration #14

Closed kevincharm closed 8 years ago

kevincharm commented 8 years ago

The code can use some cleaning up but the basic functionality is there. We need to poll Meetup for the latest event every 15 minutes or so and update the channel topic to address #4.

karlbright commented 8 years ago

15 minutes seems like a short time? It might be best just to do this every 12 hours or so with the option of a manual update?

luke-john commented 8 years ago

If we are going to use minimal module config files it might help to split them out into a config folder.

lib/meetup.js -> config/meetup.js lib/slack.js -> config/slack.js // discussed in #12

kevincharm commented 8 years ago

@luke-john Yeah that sounds good. I'm just gonna do the PR like this first then I think it would be good if 1 person does the re-arranging to be consistent. What do you think?

luke-john commented 8 years ago

👍 sounds good.

karlbright commented 8 years ago

Do you think we can hold off on this once we have the test stuff merged in and add tests for this?

kevincharm commented 8 years ago

Yeah, can do. I'll probably need some help writing useful tests for it.

karlbright commented 8 years ago

Keen to see this implemented with botkit Slack App implementation once merged. I was thinking about how to handle external services and thinking it's probably best to place them inside a lib/services directory. Just brain dumping that here for future use.

karlbright commented 8 years ago

Closing this. We should look at a new PR once we have changes for new implementation.