fendersperth / fendersbot

A group project for learning and teaching via a real code base
9 stars 3 forks source link

[WIP] Add Meetup API integration (v2) #33

Closed kevincharm closed 8 years ago

kevincharm commented 8 years ago

Migrating meetup code to new format.

kevincharm commented 8 years ago

@luke-john thanks for reviewing, made changes according to your comments. Also should we use a logger?

kevincharm commented 8 years ago

@luke-john I'm using moment-timezone now, and made a wrapper that loads the timezone info from env. How does this look?

luke-john commented 8 years ago

:thumbsup:

Tbh the wrapper feels a little like overkill.

It's probably simpler to use moment.tz.setDefault(String).

kevincharm commented 8 years ago

haha damn, I didn't even read the docs for moment-tz. So just setDefault somewhere at startup then forget about it?

luke-john commented 8 years ago

:thumbsup: