search

fenekku / moustachu

Mustache templating for Nim
65 stars 8 forks source link

Nim 0.19 compatibility #17

Closed evanwalsh closed 5 years ago

evanwalsh commented 5 years ago

Hello @fenekku 😄 This just adds a few small changes to make the library compilable with Nim 0.19. Also, I fixed the tests and benchmarks. Let me know if there's anything unclear or anything else you'd like me to do.

I can also bump the version number if you do decide to merge this.

fenekku commented 5 years ago

Hey @evanwalsh, thanks for keeping the library up-to-date with the nim/nimble update!

I took your first commit, but left aside the second one. Nimble 0.9.0 introduced a breaking change for hybrid libraries like this one, that made import moustachu fail because it was perceived as a binary library only (only the binary was installed)... I fixed it -_- . At a higher level though, the tests require the developer to install the package first, because I want to test the shipped product. This is not really a hindrance (contrary to what the Nimble docs say) since installing is really quick in this case.

Anyway, thanks for the PR! ^_^ I am closing it.