search

fenethil / bwa-u3-jammming-prj

0 stars 0 forks source link

App can't be run #1

Open ghost opened 7 years ago

ghost commented 7 years ago

Good job including your src folder, with the components and Spotify module you wrote, but where is everything else? Without all the other files created by create-react-app, your app can't be run.

In this case, since those files aren't edited after create-react-app generated them, I just created a new project and moved the missing files over to your project.

Other people looking at your portfolio won't go through this trouble, so make sure your projects have all the files they need to run successfully. Otherwise, even a great project will reflect very poorly on you.

fenethil commented 7 years ago

Hi Steve,

I could not attach the whole folder as it was too big, and github was telling me to include less than 100 files. And with all the files that are created with launching a new react app + the polyfill + surge, I'm not surprised that I can't upload everything. github too much files And when I tried to upload a compressed folder than it says that the folder is too big. github too big Without surge and the polyfill it would probably work.

Would have it be better to upload the full jamming folder after deleting the 'build' folder created by surge?