search

fenetikm / falcon

A colour scheme for terminals, Vim and friends.
MIT License
719 stars 26 forks source link

Always set background #13

Closed giorni closed 6 years ago

giorni commented 6 years ago

Are there any reason to not always set the background color as default, but only within a gui? 

" from falcon/plugin/falcon.vim  

" Put in a background colour for gui
if has("gui_running")
  hi Normal guifg=#d4d4d9 ctermfg=188 guibg=#0b0b1a ctermbg=233 gui=NONE cterm=NONE
  hi NonText guifg=#3e3e40 ctermfg=237 guibg=#0b0b1a ctermbg=233 gui=NONE cterm=NONE
endif
fenetikm commented 6 years ago

Yeah - the reason is that in the terminal you can then have the concept of an active window vs an inactive one. So when you have multiple windows and/or splits in the one terminal session you can differentiate which one you are currently typing into at a glance.

In a GUI this makes less sense so that's why there is that check for a gui.

Having said that feel free to make a PR that adds in an overriding check which will force a background colour, I'll add that as an idea to my TODO.