fenetikm / falcon

A colour scheme for terminals, Vim and friends.
MIT License
726 stars 26 forks source link

Concealed chars are looking weird (Enhancement Suggestion) #18

Closed filipekiss closed 6 years ago

filipekiss commented 6 years ago

Hey Michael! Sorry to bother again!

I've been using Falcon for a few weeks now and I'm loving it. Could I make a small suggestion?

I currently use some concealed chars in my JavaScript code and they currently look like this:

image

As you can see, right below render, there's a backwards arrow that represents my return. The current colorscheme does not apply a style to conecealed characters, so I get the weird combination above. I currently have hi! link Conceal Keyword in my .vimrc so the result is something like this:

image

I just wanted to ask you to put a color for concealed chars in falcon.vim :) Not sure if the Keyword is the best color for this, is just the easiest highlight group I can remember :P

Pretty easy this time 😬

Thank you!

fenetikm commented 6 years ago

Oh, I just messed with that in the develop branch - have a look and see what you think. I made it similar -ish to the spelling matches.

fenetikm commented 6 years ago

oh, since we are talking about suggestions, instead of conceal replacements have you considered using ligatures such as FiraCode?

filipekiss commented 6 years ago

@fenetikm I tried the develop branch. I like the color, but I'm not sure about the background. Is it supposed to be different from the default background?

image

And I do use a font with ligatures! I use conceal for some keywords and whatnots (like return, function, null)

fenetikm commented 6 years ago

My original thinking was around that you want to know that something is concealed, but that was only because the highlighting for markdown concealment was slightly wrong 😛

Have now made it essentially invisible. Give it another shot.

filipekiss commented 6 years ago

For me it's perfect! Thanks! :D

fenetikm commented 6 years ago

👍