fenetikm / falcon

A colour scheme for terminals, Vim and friends.
MIT License
719 stars 26 forks source link

Falcon overrides colorscheme settings when installed via vim-plug #23

Closed khughitt closed 5 years ago

khughitt commented 5 years ago

Summary

Falcon colorscheme settings bleed into current colorscheme when falcon is installed, even when not set as the current colorscheme.

To reproduce

  1. create a clean vim/neovim installation
  2. Install vim-plug
  3. Create configuration:
call plug#begin()                               
    Plug 'fenetikm/falcon'                      
    Plug 'dracula/vim', { 'as': 'dracula' }     
call plug#end()                                 
colorscheme dracula                             
  1. Run :PlugInstall and restart vim
  2. Run: :verbose hi Normal

Output:

Normal         xxx ctermfg=249 guifg=#b4b4b9
        Last set from ~/.config/nvim/plugged/falcon/plugin/falcon.vim

Even though falcon was never set as a colorscheme, it's settings are still applied. In particular, the background color appears to be overridden by falcon, whenever it is enabled.

To fix the issue, I can simply comment out the falcon Plug line in the vim config.

This issue does not occur for any of the twenty or so other themes tested. The order of the Plug entries does not have an impact either.

System Info

fenetikm commented 5 years ago

Ahhh, good catch. I will add in a guard to stop this from happening.

fenetikm commented 5 years ago

Ok, have updated it - please give that a shot.

khughitt commented 5 years ago

That did the trick - Thanks for the quick response and fix! Closing the issue since it has been resolved.