search

fenetikm / falcon

A colour scheme for terminals, Vim and friends.
MIT License
719 stars 26 forks source link

Terminal colors in Vim 8 are missing #30

Closed hovsater closed 5 years ago

hovsater commented 5 years ago

Opening a new terminal in Vim using the :terminal command opens a new terminal window. Unfortunately, it does not have the Falcon colorscheme applied. In Neovim, it does.

Previously this was not possible in Vim, but it is now. See discussion over at https://github.com/vim/vim/pull/2747 and see commit https://github.com/vim/vim/commit/f59c6e8cee092433d325ba21a107654a8d84f776 for the actual implementation.

See :help g:terminal_ansi_colors for more information.

fenetikm commented 5 years ago

Working on it! Thanks again for the heads-up.

fenetikm commented 5 years ago

Ok, latest version should sort it. Let me know!

hovsater commented 5 years ago

Looks great except that the background and foreground of the terminal is still off. I think those can be set using the Terminal highlight. See :help hl-Terminal and :help terminal-size-color.

fenetikm commented 5 years ago

Ok, have put that in. If you could please confirm it looks ok.

hovsater commented 5 years ago

@fenetikm works perfectly. Can't thank you enough. I really do appreciate all work put in! 🙂 ❤️