search

fenetikm / falcon

A colour scheme for terminals, Vim and friends.
MIT License
718 stars 25 forks source link

Update falcon colorscheme to remove obsolete TS* highlight groups #79

Closed nryoung closed 1 year ago

nryoung commented 1 year ago

I recently updated nvim-treesitter to the newest version and I noticed that highlighting in falcon is looking a little wonky after that. I was able to track it down to this commit here: https://github.com/nvim-treesitter/nvim-treesitter/commit/42ab95d5e11f247c6f0c8f5181b02e816caa4a4f It seems they implemented some breaking changes and removed some TS* highlight groups and doing a quick search in falcon it does look like the theme uses some of those.

Just to be sure I took screenshots of some code with the latest version of treesitter:

Screen Shot 2023-01-27 at 07 06 53

I then pinned treesitter to the commit before the one I mentioned above and I get completely different colors on the same code:

Screen Shot 2023-01-27 at 07 10 19

I am willing to take a look to see how to update the colorscheme to work with these breaking changes, but I don't have a lot of experience with writing my own colorschemes in general so it might take me a while.

Anyways, thank you for the rad colorscheme and hopefully we can get this resolved at some point.

fenetikm commented 1 year ago

Have taken a look - shouldn't be too hard to sort out. Hang tight!

fenetikm commented 1 year ago

@nryoung ok, have updated master branch - see if that does the trick.

nryoung commented 1 year ago

@fenetikm That is looking much better! Thank you for such a quick turnaround!