Inverted colors

[Zach-Johnson]

Hi - It seems like in a recent update, the background colors were inverted for splits. Previously, the darker background would be on the split that I was currently editing and now it appears to be a gray color on the editing buffer and the black background on the other split. Is that intentional? I much preferred the dark background on the split that I was currently editing.

[fenetikm]

Hmmm, strange. The intention is indeed for the active window to be dark and that's what I am seeing. Are you using Vim or NeoVim? Are you running inside of tmux? Can you please give me any other relevant environment information?

[Zach-Johnson]

I'm using NeoVim inside of iTerm 2 without tmux on a mac running El Capitan. I'll see if I can put together a minimal config to reproduce the issue.

[fenetikm]

Cool - I have just opened exactly the same - iTerm2, Tmux, Neovim and it looks fine and the active background changes as expected. It's most probably a config difference between our two configs. Do you see the problem when just inside of NeoVim without Tmux? Would be good to pull Tmux out of the equation.

[fenetikm]

Actually one question that comes to mind, which version of NeoVim are you running? The current way that I am doing the activewindow colour adjustment is NeoVim specific.

[Zach-Johnson]

I probably didn't make that clear, I'm not using tmux, just NeoVim inside iTerm2. NeoVim version is 0.2.2. I re-created the issue with a config that just pulls in the plugin and with set termguicolors enabled, which seems to be part of the issue. It seems that with termguicolors enabled, the background pulls from whatever the background is on iTerm, and the inactive split gets the Falcon background, and without termguicolors set, all backgrounds (active or inactive) are pulling from my iTerm background.

[fenetikm]

ahhh - yeah, set termguicolors is required to be set as that gives 24-bit colour which is a requirement. I will update the docs. Does that resolve it for you?

[Zach-Johnson]

No, if I have it enabled I get the lighter background on my active split and the dark background on the inactive split rather than the other way around. Hmm

[Zach-Johnson]

Okay, so in plugin/falcon.vim if I swap the colors on active and inactive it works perfectly:

" NeoVim has support for changing background colour depending on active or not
if exists('+winhighlight')
  " hi ActiveWindow guibg=NONE | hi InactiveWindow guibg=#141420
  hi ActiveWindow guibg=#141420 | hi InactiveWindow guibg=NONE 
  set winhighlight=Normal:ActiveWindow,NormalNC:InactiveWindow
endif

[fenetikm]

Ok, let's double check some things:

• iTerm2 background colour (under "Basic Colors"), I have 0b0b1a
• in the falcon directory in colors/falcon.vim, line 36 is hi Normal and guibg=NONE
• in the falcon directory in plugin/falcon.vim, line 19 the ActiveWindow guibg=NONE ?

[fenetikm]

that... makes no sense!

[Zach-Johnson]

Okay, THAT'S what it is. My iTerm2 background is a slightly lighter shade and it's lighter than 141420, so the inactive window is actually getting a darker color than the active one, which in my case is using the lighter background color that I have iTerm2 set to

[fenetikm]

bingo, phew. Did you load the included iterm2 colours (come with Falcon)?

[Zach-Johnson]

I just took a look at them, I prefer the color set up I currently have for iTerm, but I'm just going to darken up my background so it plays a little nicer. Thanks!

[fenetikm]

Hah, no problem ;) Glad we worked it out.