search

fengari-lua / fengari-web

Provides everything you need to run Fengari in the browser.
MIT License
250 stars 19 forks source link

Use CSS keyframes via sentinel-js instead of MutationObserver #18

Open daurnimator opened 7 years ago

daurnimator commented 7 years ago

Closes #15

I'm a little concerned about sentinel-js's globally visible behaviour: it adds a <style> element to the document. I think this wouldn't be acceptable in some contexts e.g. if you're writing a plugin for a page (think an ad or other embedded content)

daurnimator commented 7 years ago
| daurnimator, shouldn't we listen to modification of existing tag also ? | bgiannan: I don't think modifications to existing JS Githubissues.
  • Githubissues is a development platform for aggregating issues.