search

fengju514 / Expression-Net

Deep 3DMM facial expression parameter extraction
514 stars 123 forks source link

fixes to the code to make it run - paths, module names #4

Open adamdbrw opened 6 years ago

adamdbrw commented 6 years ago

The code as it is doesn't run - and it is not a matter of my environment, there are some errors in scripts. I guess there was a refactoring effort before the code was published, however some names and paths were not adjusted. These changes work for me. The best long-term solution would be to finish the refactoring properly, but this at least enables people to run the code.

fengju514 commented 6 years ago

Hi, Thank you so much for your advice. I will work on it to fix the issues. Thanks again.

Best, Fengju

2018-08-13 0:52 GMT-07:00 Adam Dąbrowski notifications@github.com:

The code as it is doesn't run - and it is not a matter of my environment, there are some errors in scripts. I guess there was a refactoring effort before the code was published, however some names and paths were not adjusted. These changes work for me. The best long-term solution would be to finish the refactoring properly, but this at least enables people to run the code.

You can view, comment on, or merge this pull request online at:

https://github.com/fengju514/Expression-Net/pull/4 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_fengju514_Expression-2DNet_pull_4&d=DwMFaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=fL_PdV8x_xk55s7p1ngFYA&m=0T1NrbVcFCbSgdHlH_i2JaHHGB7Eiq4qf1Eoob3L9l4&s=WK5IYM-2GveMbofZF3rWXTVh9OEH7FX27k9zWSrALgQ&e= Commit Summary

  • fixes to the code to make it run - paths, module names

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_fengju514_Expression-2DNet_pull_4&d=DwMFaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=fL_PdV8x_xk55s7p1ngFYA&m=0T1NrbVcFCbSgdHlH_i2JaHHGB7Eiq4qf1Eoob3L9l4&s=WK5IYM-2GveMbofZF3rWXTVh9OEH7FX27k9zWSrALgQ&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIAnDbP2-2DrhqIF9wG5pVe0coeX2AukjCks5uQTApgaJpZM4V6Cd2&d=DwMFaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=fL_PdV8x_xk55s7p1ngFYA&m=0T1NrbVcFCbSgdHlH_i2JaHHGB7Eiq4qf1Eoob3L9l4&s=SCfr1pkPTLrCDW0Kf9Qp7LLS29ZXwlnlJ4D541JSKKk&e= .

adamdbrw commented 6 years ago

(Try merging the code I provided and see if it works for you) You are welcome!

liny77 commented 5 years ago

Thanks @adamdbrw !! Your code solved my problem!