search

fengyanshi / FUNWAVE-TVD

43 stars 51 forks source link

Cd matrix variables not recognized by the model #35

Closed GabySalgado closed 5 years ago

GabySalgado commented 5 years ago

I noticed that FUNWAVE does not recognize the Cd matrix file when using the variables shown in the wiki (FRICTION_MATRIX & FRICTION_FILE). When I use those, the LOG file says to use instead Friction_Matrix & Cd_file. But when I do that, it still uses the Cd = 0.0 as default. There are no issues when using a fixed homogeneous Cd, but when I try to any Cd file, it does not work.

fengyanshi commented 5 years ago

you are right, the names defined were not consistent with the wiki page. I changed to FRICTION_MATRIX & FRICTION_FILE and updated the github. please try the updated version and let me know if you get correct results.

GabySalgado commented 5 years ago

Awesome! So if I recompile Makefile-Onyx-intel it should be fine? I git pulled the funwave repository and now that makefile is inside the old-version folder. Would you recommend me to use another makefile for Onyx instead?

fengyanshi commented 5 years ago

you can use the old makefile. Zhouteng is working on the documentation for the new makefiles.

GabySalgado commented 5 years ago

Ooooh cool. Thank you so much, Fengyan! I'll let you know how it goes.

GabySalgado commented 5 years ago

So far so good. Thanks for the help!