search

fengyanshi / FUNWAVE-TVD

43 stars 51 forks source link

Makefile bug in variables #36

Open mayhl opened 5 years ago

mayhl commented 5 years ago

There is a minor bug whitespace following variables assignment in the Makefile. I can across this in two places:

1) In COMPILER=intel, a space was left after 'intel' resulting in the -DINTEL flag not being added during compile time.

2) In DEF_FC, similarly I left a space after the assignment which resulted in a space in the executable file thus did not compiled due to an error (parts of the executable name after the space were interpreted as unknown flags).

zhoutengye commented 5 years ago

You can add the following lines at the beginning Make_Essential file, it should solve your problem

#-----Eliminate the leading and ending white space----
FUNWAVE_DIR := $(strip $(FUNWAVE_TVD))
WORK_DIR    := $(strip $(WORK_DIR))
COMPILER    := $(strip $(COMPILER))
PARALLEL    := $(strip $(PARALLEL))
PRECISION   := $(strip $(PRECISION))
EXEC        := $(strip $(EXEC))

DEF_FC      := $(strip $(DEF_FC))
DEF_FC_FLAG := $(strip $(DEF_FC_FLAG))
MPI         := $(strip $(MPI))
SPHERICAL   := $(strip $(SPHERICAL))
DEBUG       := $(strip $(DEBUG))