fengyanshi / FUNWAVE-TVD

43 stars 51 forks source link

MinDepthFrc and MinDepth #44

Closed zhisongli closed 3 years ago

zhisongli commented 3 years ago

In file IO.F, LineBeg:2919 ! merge two parameters into the minimum one MinDepthFrc=MAX(MinDepthFrc,MinDepth) MinDepth=MinDepthFrc

if defined (PARALLEL)

  if (myid.eq.0) WRITE(3,'(A40)')'USE MIN(MinDepthFrc, MinDepth)'

else

  WRITE(3,'(A40)')'USE MIN(MinDepthFrc, MinDepth)'

endif

LineEnd: 2927.

MinDepthFrc and MinDepth are merged into a smaller one. But the employed function is MAX instead of MIN.

Are there any typos?

The stability of Funwave v3.0 or the later is strongly affected by "MinDepthFrc". A small value of such a variable may bring divergence to numerical results, especially for simulations of a tsunami.