search

fengyuanchen / cropper

⚠️ [Deprecated] No longer maintained, please use https://github.com/fengyuanchen/jquery-cropper
MIT License
7.75k stars 1.74k forks source link

Issue with maxWidth and maxHeight on getCroppedCanvas #966

Closed BGitlin337 closed 6 years ago

BGitlin337 commented 6 years ago

Hey Fengyuanchen, I am having issues with maxWidth and maxHeight. The cropper works totally fine with width and height set, but if I want to include max width and height, the image renders mostly black image

Then, without maxWidth and maxHeight:

image

fengyuanchen commented 6 years ago

This is a bug and will be fixed in next version.

fengyuanchen commented 6 years ago

The same as #953.

BGitlin337 commented 6 years ago

Hey thanks for the quick response. Any idea on time frame for that release?

fengyuanchen commented 6 years ago

@BGitlin337 I have release a new version for this just now.

BGitlin337 commented 6 years ago

@fengyuanchen I've been working with the updated version and am still having issues. It seems like this update only fixes the issue with landscape images. If I add the maxWidth and maxHeight attributes and then crop a portrait image above the max width and height, I again get a distorted crop with black bars on the sides. If I rotate the image to be oriented as landscape, it works perfectly.