Crashing when rendering some ice traps

[guigop2]

Version 7.1.118 Fenhl-17

":settings_string": "EALSQSKAWCHGAHK62AEMMPDDSY7YAEAEH4AJAAACJPAE4JZBA637AA4RE6A2EWKAAAAAAAJS9RAJB6V8VAN9EA2USFA",

":seed":
"NYBSTYHRV0",

seems whenever a skulltula that contains an ice trap is killed, i crash immediately. so far it has happened at :

"Market GS Guard House":                                {"item": "Ice Trap", "model": "Ocarina"},

"DMT GS Falling Rocks Path":                            {"item": "Ice Trap", "model": "Light Arrows"},

played on wii vc

[fenhl]

This doesn't seem to be limited to gold skulltula locations. Seed 1413860 crashes when loading the upper part of Zora River, which has an ice trap on the freestanding heart piece.

[guigop2]

"HC GS Storms Grotto":                                  {"item": "Ice Trap", "model": "Progressive Wallet"},

heres another one. btw botw feels really laggy in this seed

[fenhl]

Findings so far:

• Seems to be independent of emulator, or at least BizHawk crashes as well.
• Not all ice trap models crash the game when being loaded, e.g. setting the freestandings in Saria's house to ice traps cloaked as hover boots doesn't crash.
• However, it seems that ice traps that don't crash don't get cloaked correctly, e.g. the Saria's ice traps are displayed as recovery hearts and not as hover boots.
• The issue does not occur on main Dev.

From this, my guess is that I somehow broke something related to ice trap cloaks, and different types of locations either react by rendering the wrong model or crashing.

[guigop2]

yeah heres another one that isnt gold skulltula

"Hideout 1 Torch Jail Gerudo Key":                      {"item": "Ice Trap", "model": "Small Key (Shadow Temple)"},

[guigop2]

also not just botw, but a lot of the dungeons seem to lag a lot. not like usual vc/n64 lag is this consequence of the settings?

[fenhl]

The lag is most likely unrelated.

[fenhl]

Thanks to @mracsys for identifying the cause and providing a fix.