search

fenimore / DemocracyDroid

Android application for watching Democracy Now! The war and peace report
https://play.google.com/store/apps/details?id=com.workingagenda.democracydroid
GNU General Public License v3.0
24 stars 2 forks source link

Reimplement ProgressBar #34

Closed fenimore closed 6 years ago

fenimore commented 7 years ago

I removed the ProgressBar, see d900e71f48b8b72e4d69ab45af314156a743a49e 

       <ProgressBar
-            android:layout_centerHorizontal="true"
-            android:id="@+id/sBar"
-            android:minHeight="20dip"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"/>

So that way the swipe to refresh is the only refresh animation. But when first opening the app, it's nice to have that yellow ProgressBar, so @DerrickRocha suggested to make

it so the yellow loading icon doesn't get displayed when a pull to refresh happens. We could pass a Boolean into GetStoryFeed and GetVideoFeed classes indicating if we should show the loading screen. We can check for it in the onPostExecute method in those classes and show the icon if true.

fenimore commented 6 years ago

I think @DerrickRocha fixed this?