search

fenimore / DemocracyDroid

Android application for watching Democracy Now! The war and peace report
https://play.google.com/store/apps/details?id=com.workingagenda.democracydroid
GNU General Public License v3.0
24 stars 2 forks source link

TONS of QoL improvements #56

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 3 years ago

I suppose every commit speaks for itself, because making the list of changes in each commit like I usually do in other PRs would be too long and confusing here (17 commits lol).

I've built and tested APKs the whole way through, and they work great :)

Please leave comments if you have any questions, thanks!

Here's an APK for testing (it has a slightly different package name so you can test the current version and this build side-by-side: app-release.zip

fenimore commented 3 years ago

Hi! Thanks so much I'll take a look soon :relaxed:

fenimore commented 3 years ago

Hi @TacoTheDank ! Thank you very much for these updates --

I see there is some binding pattern you're using, which I more or less understand

As I left in a comment, could you speak to the gradle binary files and script updates you provided?

Also I figure you used some automated tooling for some of this refactoring? If so, could you please provide a little explanation as to what tools you used (for my own edification :relaxed: )

Thanks again!

TacoTheDank commented 3 years ago

@fenimore

As I left in a comment, could you speak to the gradle binary files and script updates you provided?

Yes, take a look 👍

Also I figure you used some automated tooling for some of this refactoring? If so, could you please provide a little explanation as to what tools you used (for my own edification ☺️ )

Sure!

Reformat codestyle to an .editorconfig utilized the code reformatting tool (shortcut is Ctrl+Alt+L).

Some of Migrate to AppCompat where useful used the "Migrate to AppCompat" option found in AS's Refactor tab.

Convert icons to vector drawables utilized AS's vector asset generation tool.

Automatic cleanup by Studio was done using Ctrl+Alt+L like before, but checking the "cleanup code" option as well.

Lint cleanup is one where I really just went through and manually corrected a bunch of lints, but there's linting tools in AS's Analyze tab (the first three options) that can inspect the project for lints, as well as correct them.

Everything else was pretty much done manually.

fenimore commented 3 years ago

Amazing thank you again! I'll try to keep these clean code tools in mind :relaxed:

TacoTheDank commented 3 years ago

@fenimore I noticed you bumped the version name and code. Did you upload a new version to the play store?

fenimore commented 3 years ago

Hi! Yes, so I've updated the release. This will automatically update f droid.

I haven't added this app to the Play Store yet actually, I was thinking I'd wait a little while before doing so and see how Fdroid people like it

fenimore commented 3 years ago

Oh, actually @TacoTheDank I was confused earlier, I thought this comment was for a different application! This Is very much on the Play Store! and I haven't released it yet I was testing it for a little while (I thought maybe a week or so), before releasing to the Playstore