search

fenimore / DemocracyDroid

Android application for watching Democracy Now! The war and peace report
https://play.google.com/store/apps/details?id=com.workingagenda.democracydroid
GNU General Public License v3.0
24 stars 2 forks source link

QoL improvements 2 #58

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 3 years ago

Seeing the stuff added in the download tab commit gave me agita, so I had to do this again, sorry.

I didn't do the ViewBinding though, since downloading didn't seem to work correctly during testing (notifications were glitchy, downloads didn't show up in download tab despite having downloaded to device). Maybe that just has to do with the code (or my device that uses Android 10) and not ViewBinding. I'll do it in another PR, I guess.

fenimore commented 3 years ago

Oh thank you again @TacoTheDank ! However, there is a branch add-download-tab! There are changes not in master for a WIP getting these downloads back (I'm stuck on getting exoplayer to play a local URI 🤷 ) see https://github.com/fenimore/DemocracyDroid/pull/57

I need to correct the merge conflict 🤔 there and then finish those changes -- maybe you'd prefer branching off of those changes (I haven't made time to work on it lately)

TacoTheDank commented 3 years ago

@fenimore yeah the PR for that branch has conflicts that need to be fixed, so I figured I would make it to master.

fenimore commented 3 years ago

Thanks again @TacoTheDank !!