fenix-hub
commented
4 years ago Hi @eddex , Thank you very much for this PR. I agree with everything you have changed, applying the style guide should've been one of the first priorities before releasing the plugin, but time and new features forced me to set aside the style. So thank you very much for taking your time on styiling better this plugin, really appreciated :) Just to clerify this now so I can give you a straight line and you will be able to work freely as you prefer:
- I'd prefer to use tabs instead of spaces for indentations.
Not only because it is something mentioned in the style guide, but mostly because I've always used tabs and they have literally been implemented just for this. They will let people notice errors in indentation easily, and you can always change how wide tabs are in the editor settings without changing how other people sees them. But anyway, I'm not a "Tab fan". I'm not going to post articles about how tabs are good in opposition to spaces and get angry about this stuff. So if you want to fix the scripts that contains spaces just replace them with tabs, then if you want we can always talk about it and choose the better option :) Before merging this request I'll wait for your response and eventually the latest fix with the sapces/tabs replacement. Thank you!
eddex
In this PR I applied the official GDScript style guide to the code for the LineChart2D. See #13 for more information.
The following was done:
The style guide suggests to use tabs instead of spaces. I personally prefer spaces over tabs because with spaces the code looks the same in every editor. However, some of the files in this repo use spaces and some use tabs, therefore I wasn't sure what you prefer @fenix-hub and just kept it like it already was in this file.