fenix-hub / godot-engine.jwt

JSON Web Token library for Godot Engine written in GDScript
https://nicolosantilio.com/godot-engine.jwt
MIT License
51 stars 11 forks source link

Variables shadow already-declared variables #26

Closed brownoxford closed 11 months ago

brownoxford commented 11 months ago

Bug report

There are a number of function parameter names that shadow already-declared variable names, e.g.

W 0:03:38:0605   The local function parameter "leeway" is shadowing an already-declared variable at line 6.
  <GDScript Error>SHADOWED_VARIABLE
  <GDScript Source>JWTVerifierBuilder.gd:36

This isn't a bug per-se, but it can "lead to confusion, as it may be unclear which variable subsequent uses of the shadowed variable name refer to..."

PR forthcoming