search

fennb / phirehose

PHP interface to Twitter Streaming API
709 stars 189 forks source link

Replace count() > 0 with !empty() (fix PHP 7.2 warnings) #113

Closed exelotl closed 6 years ago

exelotl commented 6 years ago

PHP 7.2 now emits a warning when calling count with a non-countable parameter (see https://wiki.php.net/rfc/counting_non_countables) which was happening in a couple of places with variables that happened to be null.

irazasyed commented 6 years ago

@fennb Please merge this! Facing this issue since I installed.

povesteam commented 6 years ago

@fennb PHP 7.2 is crying after your merge button!

@geckojsc Thanks for the patch, I applied it directly in vendor/fennb/phirehose and it works perfectly. https://github.com/fennb/phirehose/pull/113.patch

freekmurze commented 6 years ago

@fennb This seems to be the right fix for the problem. If you have the time could you please merge this and tag a new version?

vesper8 commented 6 years ago

Could you please merge this @fennb ? Lots of packages dependent on yours are failing on 7.2

DevDavido commented 6 years ago

Would be great if you could merge it please @fennb?

fennb commented 6 years ago

Merged. Sorry about the delay, all!

freekmurze commented 6 years ago

🎉🎉🎉 thanks!

On Thu, 15 Mar 2018 at 15:10, Fenn Bailey notifications@github.com wrote:

Merged. Sorry about the delay, all!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fennb/phirehose/pull/113#issuecomment-373388459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdiDedHt3vjitKCdL6f3X4xLaN9hoydks5tenY4gaJpZM4PlvyX .

-- Freek Van der Herten https://spatie.be +32 495 84 27 91

alessandrobelli commented 4 years ago

Merged but not tagged 😞