search

fennerm / flashfocus

Simple focus animations for tiling window managers.
MIT License
748 stars 10 forks source link

flashfocus is removing transparency #58

Closed adelin-b closed 3 years ago

adelin-b commented 3 years ago

Hello, I just noticed that when flashfocus is triggered it remove the original transparency set through a previous xprop. (using devilspie or glassit in vscode for example) So I think instead of blinking and going full opacity it should save the current xprop setting and restore them

bug flashfocus xprop2

fennerm commented 3 years ago

I have considered this implementation but it adds a lot of incidental complexity. I'm wondering, can you achieve the behavior you're looking for by setting flash rules in your config for vscode etc?

adelin-b commented 3 years ago

I do not understand what you call a flash rule in my config exactly, vscode or xprops previously setted properties cannot be aware that they are getting flashed by flash focus.

adelin-b commented 3 years ago

I think the param default_opacity isn't correctly set to the actual default opacity of the window

fennerm commented 3 years ago

@adelin-b There are instructions for setting up flash rules in https://github.com/fennerm/flashfocus/wiki#defining-window-specific-flash-rules-in-config-filei (and also the config file itself). If you set a specific default-opacity for vscode in a flash rule the window will be returned to that opacity at the end of the flash.

fennerm commented 3 years ago

Hey @adelin-b closing this issue but feel free to reopen if you can't get the flash rules working how you want them.