fennerm / flashfocus

Simple focus animations for tiling window managers.
MIT License
748 stars 10 forks source link

feat: set proc title to flashfocus if setproctitle lib present #69

Closed cyrinux closed 1 year ago

fennerm commented 2 years ago

Sorry @cyrinux I realize this PR has been sitting for a long time. If you are still interested in getting this merged, could you give a little background on the motivation for the change?

cyrinux commented 2 years ago

Hi @fennerm it was just comestic to cleanup my ps tree 😁 You can close or merge, don't worry.

fennerm commented 1 year ago

Okay I'm gonna go ahead and close this one @cyrinux. Reticent to add an external dependency unless the benefit is clear. If anyone disagrees, please feel free to comment on the PR and we can revisit. Thanks for going to the trouble of making the PR :pray:

cyrinux commented 1 year ago

No problem but it was an optional dep 😉

fennerm commented 1 year ago

Yeah totally understood. There's still a cost there as we'd need to support it and fix bugs from upstream. As I say, its definitely something we could support if you or others can make a case for why its needed :)