fennerm / flashfocus

Simple focus animations for tiling window managers.
MIT License
748 stars 10 forks source link

lints #74

Closed Artturin closed 1 year ago

Artturin commented 1 year ago

@fennerm I searched the commits and found you previously formatted with black so I did it too

I will try to get the reformatted fastentrypoints.py upstreamed

fennerm commented 1 year ago

Thanks for the cleanup @Artturin. Curious what line length did you use for black? I've been using '-l 100' so far which might explain why there's so much wrapping going on here. We should probably have a config file for black checked in 😶

Artturin commented 1 year ago

Thanks for the cleanup @Artturin. Curious what line length did you use for black? I've been using '-l 100' so far which might explain why there's so much wrapping going on here. We should probably have a config file for black checked in no_mouth

I ran black without any options

I added a pyproject.toml with line-lengths set to 100

Artturin commented 1 year ago

Would it be okay with you if I tried converting the project to use the poetry build system?

fennerm commented 1 year ago

Would it be okay with you if I tried converting the project to use the poetry build system?

Go for it! Don't have much experience with poetry but have only heard good things

Artturin commented 1 year ago

with poetry the fastentrypoints.py may not be needed anymore :smile: according to a comment by it's creator

Well, I have to admit, I rarely use it myself anymore. I've switched most of my own stuff to Poetry. I am looking at adding a couple tests, however, at the request of a user.

https://github.com/ninjaaron/fast-entry_points/pull/12#issuecomment-496162519

Artturin commented 1 year ago

ready to merge will do poetry migration and other lint fixing in separate PRs