fennicahub / fennica

R tools for Fennica (Finnish national bibliography)
http://fennica-fennica.rahtiapp.fi
Other
0 stars 5 forks source link

Tab-separated html tables (clear columns)? #52

Open antagomir opened 1 year ago

antagomir commented 1 year ago

Regarding the html tables, would it be possible to have tab-separated html tables, instead of space-separated ones (e.g. http://fennica-fennica.rahtiapp.fi/dataTable/data_table.html?path=../output.tables/publication_place_conversion_nontrivial.csv). This could improve readability. Or is this a conscious design choice somehow?

NRV2ouf commented 1 year ago

The problem is that the file we have on the repository is not tab-separated. The columns on this file are separated with spaces.

A while ago (, when I finished to work on the HTML tables), I already raised the issue on slack that I found a couple of files that had the bad formatting.

sep=';'

I don't know how this files were generated, and that is why I didn't fix them at the time. If you told me how to regenerate them, I'd gladly fix it !

antagomir commented 1 year ago

Ah, great!

These files are generated by the R scripts for data harmonization, and it should be possible to identify the generating R scripts with simple grep. The export functions can define the separator.

We should unify the separator conventions. I suggest tab as the default separator unless there are arguments otherwise.

-> Update the generating scripts to use tab separator -> Rerun the pipeline (perhaps @JuliaMatveeva217 can help with that?) -> Check that the html table rendering gets done correctly

At the same go, it might be more clear to rename the files from .csv to .tsv (for tab-separated file).