search

fennifith / Metronome-Android

A lightweight, well designed metronome app for Android.
https://play.google.com/store/apps/details?id=james.metronome
Apache License 2.0
111 stars 26 forks source link

[untested] Silence notification sound #19

Closed READ10 closed 4 years ago

READ10 commented 4 years ago

This patch reduces the priority of the metronome start notification to IMPORTANCE_LOW which should silence the notification on metronome start. If the notification has IMPORTANCE_DEFAULT by design, please ignore and sorry for the bother. Caveats: I've written a couple of trivial Android apps, but I'm no expert and this patch is completely untested (not even built).

fennifith commented 4 years ago

No, you're completely right - there's no reason for IMPORTANCE_DEFAULT here. I generally don't turn my notification sounds on, so I never would've noticed if this was an issue...

No promises that this'll be released to the Play Store anytime soon - there's a bunch of stuff in develop I need to fix up before the next release - but it'll get there eventually, I hope. Either way, thank you for contributing!

READ10 commented 4 years ago

Cool, thanks for a nice app and merging!