search

fennifith / Status

A no-root status bar replacement for Android.
https://play.google.com/store/apps/details?id=com.james.status
Apache License 2.0
127 stars 29 forks source link

Include gradle/wrapper/ in repository #127

Closed Rudloff closed 6 years ago

Rudloff commented 6 years ago

[A short description of the issue] gradlew does not work.

[The error report of the crash, if applicable]

Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

[The expected behavior of the app in this situation]

The build should start. I think the gradle/wrapper/ directory is missing.

App Version: [The version of the app that the issue occurs on] 954f32c3304abb732d1b8af35408d420b1069ec7

fennifith commented 6 years ago

I don't include the gradle/wrapper/ directory in any of my projects as it is normally auto-generated by Android Studio when you import a new project. After reading some SO questions on the matter, it seems that the common practice is to include it, so I may do so in the future, but it shouldn't be necessary in order to build the project yourself.

If you are compiling your own version for personal use (not for contributing), I would recommend working from a3e3ad8 instead, as much of the functionality is broken in the latest version due to #111 and #113 being in a state of partial completion.

Rudloff commented 6 years ago

Oh I see. I actually never use Android Studio, I always build everything directly from the CLI.

fennifith commented 6 years ago

@Rudloff if you need it, this thingimabob says that gradle wrapper --gradle-version 4.4 should do the thing.