search

fenomas / noa

Experimental voxel game engine.
MIT License
611 stars 87 forks source link

FINAL FIX: Adding Fog #146

Closed sourcerose closed 3 years ago

sourcerose commented 3 years ago

Sorry, this is the third PR haha! This is just a proof of concept. Not really Necesessary to add in, but would be a nice touch in my opinion.

fenomas commented 3 years ago

Hi, this looks great but I think it would be better to add it to noa-examples/test than to the core engine. The reason being that fog behavior isn't directly affected by voxels, so if different games want to handle fog in various ways then noa doesn't really need to know about that.

However it would be good to have this in the examples repo, so that it's easy to test whether noa is working correctly with fog, and also so that other users have a reference for how to add fog to their game.

What do you think?

sourcerose commented 3 years ago

Should I make a PR in the examples repo?

fenomas commented 3 years ago

That would be great, perhaps as noa-examples/src/test/fog.js or similar, as a single module people can reference.

sourcerose commented 3 years ago

Ok, I submitted a PR