search

fent / node-feedsub

Subscribes to RSS/Atom/JSON feeds and notifies on new items.
MIT License
196 stars 19 forks source link

Adding emitFirstOnStart feature #51

Closed atwellpub closed 3 years ago

atwellpub commented 4 years ago

Hi there!

I'm trying to add an emitFirstOnStart to post the latest item once the feed watch starts. I'm not sure if I have done it right an wanted to submit the change to you for review and consideration.

fent commented 4 years ago

hi, thanks for the PR! do you mind adding a test for this?

I'm trying to add an emitFirstOnStart to post the latest item once the feed watch starts.

how about emitLastOnStart for the name? that makes more sense in my head as for what it does, what do you think?

this option would also have to be added to the readme.

one more thing on the PR, there are some styling changes that I don't think are part of the PR, your editor must've introduced them in there for whatever reason. and in general, try to follow the same coding style as the file already has to keep things consistent. this includes spacing, new lines, and comments.