fent / node-feedsub

Subscribes to RSS/Atom/JSON feeds and notifies on new items.
MIT License
196 stars 19 forks source link

tiny-typed-emitter should be (production) dependencies #59

Closed jesec closed 3 years ago

jesec commented 3 years ago

Otherwise TS projects that depends on feedsub need to add tiny-typed-emitter to their devDependencies. That messes up the dependency chain.

Additionally, FeedItem type should be (re)exported via export {FeedItem} from 'feedme';.

fent commented 3 years ago

hi, thanks for the feedback. this change was just pushed, i wasn't sure about putting tiny-typed-emitter in either dependencies or devDependencies. but now i see that compiled code in dist/feedsub.js does reference it. i don't know why i didn't think to check, so thanks for letting me know.