Readable Stream Does Not Emit 'finish' or 'end' Event Causing Code to Not Terminate

[UltronOne]

Description

I am experiencing an issue with the ytdl-core package where the readable stream does not emit the 'finish' or 'end' event, causing the code execution to hang and not terminate as expected.

Details

I have used the ytdl-core for downloading the audio stream from a YouTube video and piping it to a writable stream to save as an MP3 file. However, it seems that the events ('finish' and 'end') that signify the completion of the streaming are not being emitted, leading to an indefinite wait state.

Here's a minimal reproducible example:

import fs from "fs";
import ytdl from "ytdl-core";

// Video ID to download
const videoId = "4WEQtgnBu0I";

// Destination file for audio
const outputFilePath = "output/audio.mp3";

// Ensure the directory exists
fs.mkdirSync("output", { recursive: true });

console.log("YTDL Start");

async function downloadAsAudio(ytUrl: string, filePath: string) {
  return new Promise(async (resolve) => {
    ytdl(ytUrl, {
      filter: "audioonly",
      quality: "highestaudio",
    })
      .pipe(fs.createWriteStream(filePath))
      .on("finish", () => resolve("Downloaded"));
  });
}

await downloadAsAudio(
  `https://www.youtube.com/watch?v=${videoId}`,
  outputFilePath
);

Expected Behavior

• The stream should emit a 'finish' or 'end' event when the audio download and file write operation is completed.

Actual Behavior

• The 'finish' or 'end' events are not triggered, resulting in the code hanging and not terminating properly.

Additional Information

• Node.js version: [Your Node.js version]
• ytdl-core version: [Your ytdl-core version]
• Operating System: [Your OS]

I appreciate your help in resolving this issue.

Thank you!

[mtripg6666tdr]

It seems you piped the ytdl stream to a fs stream, so it is the fs stream that doesn't emit either 'finish' or 'end' event. If you'd like to attach an event handler to the fs stream, which is called when finishing the stream, you can listen 'close' event, rathar than 'finish' or 'end' iirc.