fentie / netbeans-colors-solarized

Solarized Dark color scheme, implemented for NetBeans
http://ethanschoonover.com/solarized
226 stars 36 forks source link

No color set for PHP 'Mark Occurrences' #3

Closed helion closed 13 years ago

helion commented 13 years ago

Netbeans will highlight multiple occurrences of a variable or other elements when the caret sits on one for more than a moment. This theme has the color for that highlight set to inherit which means it isn't visible.

On my own copy I've set it to be the same as the 'Highlight Search' background - rgb(56, 86, 111) - but I suppose anything gives good contrast would work well.

I don't know if other languages need a similar fix or not.

fentie commented 13 years ago

Thanks for the report, I'll take a look at this later (hopefully later today) when I'm done with work.

Date: Thu, 19 May 2011 21:08:32 -0700 From: reply@reply.github.com To: fentie@hotmail.com Subject: [netbeans-colors-solarized] No color set for PHP 'Mark Occurrences' (#3)

Netbeans will highlight multiple occurrences of a variable or other elements when the caret sits on one for more than a moment. This theme has the color for that highlight set to inherit which means it isn't visible.

On my own copy I've set it to be the same as the 'Highlight Search' background - rgb(56, 86, 111) - but I suppose anything gives good contrast would work well.

I don't know if other languages need a similar fix or not.

Reply to this email directly or view it on GitHub: https://github.com/fentie/netbeans-colors-solarized/issues/3

fentie commented 13 years ago

Ok, just pushed several changes. The only guidance I had to go on from the main color scheme was to use base02 for the Dark version and base2 for the Light version, so I set those to the highlight colors for PHP and JavaScript. Please pull down the changes and let me know if that meets your needs, or if you think there's a better color to use that's already part of Solarized.